[Webkit-unassigned] [Bug 119790] [Qt] Activate Page Visibility API layout tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 20 01:39:12 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=119790





--- Comment #15 from Benjamin Dupont <bdupont at nds.com>  2013-08-20 01:38:41 PST ---
(In reply to comment #14)
> The unskipped tests are flaky. Are you sure you don't need to reset the visibility?
I don't understand why is it necessary to reset the visibility at the end of the test because it's set when the QWebPage is created. 
The problem with our Qt implementation is that we haven't the possibility to specify an initial state (Page API offer this possibility but not our QWebPage API). We don't provide this feature because we just need to initial the state when we are creating the Page.
In the DRT layout reset function, if we call the QWebPage setVisibilityState function with visible in parameter, then an event will be fired to the JS application and test results won't match with the expected file...

When I manually launched the unskipped tests one by one (PSA my first comment), I obtained the expected results.

Thus, if this is really the root cause, we can add a new QWebPage API to reset this visibility state but it will be used only for layout tests...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list