[Webkit-unassigned] [Bug 119845] Implement CSS Image filter() function

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 19 08:58:55 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=119845





--- Comment #13 from Brent Fulgham <bfulgham at webkit.org>  2013-08-19 08:58:25 PST ---
(From update of attachment 208844)
View in context: https://bugs.webkit.org/attachment.cgi?id=208844&action=review

> Source/WebCore/css/CSSParser.cpp:9279
> +    for (CSSParserValue* value = valueList->current(); value; value = valueList->next()) {

I know you didn't write this logic, but it generates a warning when building because 'value' shadows the second argument passed to this method.

Can you double-check that the use of 'value' inside this loop is unrelated to the return value argument?  I think it would be better to rename this inner loop variable to avoid confusion.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list