[Webkit-unassigned] [Bug 119982] Make Element::attach non-virtual

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=119982





--- Comment #5 from Antti Koivisto <koivisto at iki.fi>  2013-08-18 12:35:13 PST ---
(In reply to comment #4)
> Two thoughts about this that we already discussed on IRC, crystallizing here:
> 
> 1. We should make the has-custom-style-resolve-callbacks bit part of the node creation flag-mask.

This is a good idea.

> 2. It might be good to always call the base class willAttachRenderers()/didAttachRenderers() for consistency. As long as "useless" base class implementations are inline, there will be zero overhead.

I'm not so sure about this. The call is unnecessary in most cases and calling no-op functions for "consistency" feels strange. willAttachRenderers() and pals are currently private so calling them unnecessarily will fail. Easy to test.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.