[Webkit-unassigned] [Bug 119829] IAccessibleText/2 implementation for AppleWindows port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=119829





--- Comment #5 from chris fleizach <cfleizach at apple.com>  2013-08-16 09:07:27 PST ---
(From update of attachment 208876)
View in context: https://bugs.webkit.org/attachment.cgi?id=208876&action=review

> Source/WebKit/win/AccessibleText.cpp:78
> +    VisiblePosition caretPosition = m_object->renderer()->document()->frame()->page()->dragCaretController()->caretPosition();

there's a document() method on axObject that you can call that will check if renderer() exists. you should probably verify that that document exists after retrieving

> Source/WebKit/win/AccessibleText.cpp:123
> +    if (m_object->renderer()->document()->frame()->selection()->isNone())

ditto for document()

> Source/WebKit/win/AccessibleText.cpp:135
> +    Node* node = m_object->renderer()->node();

there's a node() method on axObject. you should prob. verify it exists after retrieving

> Source/WebKit/win/AccessibleText.cpp:260
> +    int textLength = m_object->text().length();

length() returns an unsigned here

> Source/WebKit/win/AccessibleText.cpp:324
> +    int textLength = m_object->text().length();

do you want to use m_object->textLength() here in case of password fields?

> Source/WebKit/win/AccessibleText.cpp:384
> +    m_object->renderer()->document()->frame()->selection()->clear();

ditto about document()

> Source/WebKit/win/AccessibleText.cpp:394
> +    Node* node = m_object->renderer()->node();

ditto about node()

> Source/WebKit/win/AccessibleText.cpp:413
> +HRESULT AccessibleText::nCharacters(long *characters)

* in wrong place

> Source/WebKit/win/AccessibleText.cpp:492
> +HRESULT AccessibleText::newText(IA2TextSegment *newText)

* in wrong place

> Source/WebKit/win/AccessibleText.cpp:500
> +HRESULT AccessibleText::oldText(IA2TextSegment *oldText)

* ditto

> Source/WebKit/win/AccessibleText.cpp:510
> +HRESULT AccessibleText::attributeRange(long offset, BSTR filter, long *startOffset, long *endOffset, BSTR *attributeValues)

* ditto

> Source/WebKit/win/AccessibleText.cpp:527
> +        return m_object->renderer()->document()->frame()->selection()->start().offsetInContainerNode();

ditto about document()

> Source/WebKit/win/AccessibleText.cpp:537
> +    Document* document = m_object->renderer()->document();

ditto about document()

> Source/WebKit/win/AccessibleText.h:40
> +	virtual HRESULT STDMETHODCALLTYPE attributes(long offset,	long *startOffset, long *endOffset,	BSTR *textAttributes);

tabs exist in this line

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.