[Webkit-unassigned] [Bug 98350] [GTK] accessibility/aria-invalid.html times out

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=98350





--- Comment #3 from Anton Obzhirov <a.obzhirov at samsung.com>  2013-08-16 03:18:48 PST ---
(From update of attachment 208804)
View in context: https://bugs.webkit.org/attachment.cgi?id=208804&action=review

>> LayoutTests/ChangeLog:7
>> +        * platform/gtk/TestExpectations:
> 
> You need a small description here

ok

>> Source/WebCore/ChangeLog:13
>> +        (webkitAccessibleGetAttributes):
> 
> I know not everyone does it (even though it's in the guidelines), but I normally like to have shorts descriptions for every function touched in the ChangeLog.

ok

>> Source/WebCore/accessibility/atk/AXObjectCacheAtk.cpp:169
>>      }
> 
> You do not need { } if it's a one line branch

ok

>> Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:898
>> +
> 
> You probably need to add this aria-invalid specific mapping to WKTR too

will do

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.