[Webkit-unassigned] [Bug 76677] AXPress event coordinates are always sent as (0, 0)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 14 14:49:48 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=76677





--- Comment #21 from chris fleizach <cfleizach at apple.com>  2013-08-14 14:49:21 PST ---
(From update of attachment 208759)
View in context: https://bugs.webkit.org/attachment.cgi?id=208759&action=review

> LayoutTests/platform/mac/accessibility/press-targets-center-point.html:10
> +<button id="button" style="-webkit-transform:translate(240px, 240px); height:30px; width:48px;">Press</button>

you should also have a non transformed case

> LayoutTests/platform/mac/accessibility/press-targets-center-point.html:21
> +    actual.innerHTML = "Waiting for press";

this seems unncessary

> LayoutTests/platform/mac/accessibility/press-targets-center-point.html:36
> +        button.focus();

you don't need to focus first, you can just call accessibilityController.accessibleElementById("id")

> Source/WebCore/dom/MouseEvent.cpp:263
> +SimulatedMouseEvent::SimulatedMouseEvent(const AtomicString& eventType, PassRefPtr<AbstractView> view, PassRefPtr<Event> underlyingEvent, PassRefPtr<Element> targetElement)

I don't think Element needs to be a pass ref ptr, because you don't need to maintain a reference to that object beyond its creation.

> Source/WebCore/dom/MouseEvent.cpp:286
> +        m_screenLocation = IntPoint(0, 0); // FIXME: m_screenLocation should be set here.

there's a screenRect() method on Element that might help

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list