[Webkit-unassigned] [Bug 117735] [curl] Improve multipart response handling

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 13 04:38:22 PDT 2013


--- Comment #8 from Peter Gal <galpeter at inf.u-szeged.hu>  2013-08-13 04:37:57 PST ---
(In reply to comment #6)
> (From update of attachment 206765 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=206765&action=review
> > Source/WebCore/platform/network/curl/MultipartHandle.h:73
> > +    ResourceHandle *m_resourceHandle;
> * should be part of the type.
> Since ResourceHandle is not 'owned' by this object, and the MultipartHandle cannot exist without a resource handle, I wonder if this should be a reference?

In case of the FormDataStream the ResourceHandle is also a simple pointer (http://trac.webkit.org/browser/trunk/Source/WebCore/platform/network/curl/FormDataStreamCurl.h#L54) that's why I did the same here. Also note that in the headerCallback method the ResourceHandle ('job' variable) is pointer and for the 'client()->didReceive*' calls a pointer is required. Still I could change this to be a reference if you think that'll be better.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list