[Webkit-unassigned] [Bug 119739] Precision updates in WebAudio

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=119739





--- Comment #4 from Christophe Dumez <dchris at gmail.com>  2013-08-13 03:53:50 PST ---
(From update of attachment 208614)
View in context: https://bugs.webkit.org/attachment.cgi?id=208614&action=review

>>> Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:-246
>>> -    for (unsigned channelIndex = 0; channelIndex < priv->bus->numberOfChannels(); channelIndex++) {
>> 
>> Looks unrelated?
> 
> This is unrelated, and how is this an optimization? This is how the GLib docs advize on how to fill a GSList. It's not the first time people try to optimize this code :)

Well, it avoids a call to g_slist_reverse() so it can only be faster IMHO. That said, this is a micro-optimization considering the number of channels (and thus the size of the list).
In any case, this should not be in this patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.