[Webkit-unassigned] [Bug 119710] Use the correct preprocessor in shouldRepaintFixedBackgroundsOnScroll()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 12 18:49:50 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=119710





--- Comment #6 from Seokju Kwon <seokju at webkit.org>  2013-08-12 18:49:26 PST ---
(In reply to comment #4)
> (In reply to comment #3)
> > (From update of attachment 208579 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=208579&action=review
> > 
> > >> Source/WebCore/rendering/RenderObject.cpp:129
> > >> +#if !ENABLE(FAST_MOBILE_SCROLLING) || (ENABLE(FAST_MOBILE_SCROLLING) && !PLATFORM(QT))
> > > 
> > > That’s the same as just change && to ||, why make it so complicated?
> > 
> > In other words, this is:
> > 
> >     #if !A || (A && !B)
> > 
> > Which is the same as:
> > 
> >     #if !A || !B
> 
> Just check it explicitly. You're right.
> It could be so complicated. Thanks.

Fixed it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list