[Webkit-unassigned] [Bug 119515] [WebGL] Vertex attribute binding validation method

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 12 10:31:08 PDT 2013


--- Comment #8 from Christophe Dumez <dchris at gmail.com>  2013-08-12 10:30:44 PST ---
(From update of attachment 208519)
View in context: https://bugs.webkit.org/attachment.cgi?id=208519&action=review

> Source/WebCore/ChangeLog:6
> +        This patch refactors WebGLRenderingContext code by move a vertex

"by moving"

> Source/WebCore/ChangeLog:7
> +        attribute binding validation to the separate method. It is now

"to a separate"

> Source/WebCore/ChangeLog:9
> +        code is more readable and more clear now. 

"more readable and more clear": pretty much means the same. Probably one is enough.

> Source/WebCore/ChangeLog:13
> +        No new tests. Covered by existing tests.

There is no behavior change, right? If so, it is a good idea to say so in the Changelog.

> Source/WebCore/html/canvas/WebGLVertexArrayObjectOES.h:61
> +        inline bool isBound() const { return bufferBinding && bufferBinding->object(); }

inline is redundant here.

> Source/WebCore/html/canvas/WebGLVertexArrayObjectOES.h:62
> +        inline bool validateBinding() const { return !enabled || isBound(); }


Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list