[Webkit-unassigned] [Bug 108881] Canvas fillText and measureText handle ideographic spaces differently

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=108881





--- Comment #26 from Rashmi Shyamasundar <rashmi.s2 at samsung.com>  2013-08-12 00:31:03 PST ---
(In reply to comment #24)
> (From update of attachment 208423 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=208423&action=review
> 
> > Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp:98
> > +// Spec : http://www.whatwg.org/specs/web-apps/current-work/multipage/common-microsyntaxes.html#space-character
> > +static inline bool isHTMLSpace(UChar c)
> > +{
> > +    return (c == 0x0009 || c == 0x000A || c == 0x000B || c == 0x000C || c == 0x000D);
> > +}
> 
> This function already exists in HTMLParserIdioms.h and you should use the version from there instead of adding a new one.

Using the function isHTMLSpace() defined in HTMLParserIdioms.h, will cause the below layout test to fail -

LayoutTests/canvas/philip/tests/2d.text.draw.space.collapse.nonspace.html

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.