[Webkit-unassigned] [Bug 119625] [Performance]making HTMLSelectElement::usesMenuList() inline

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=119625





--- Comment #9 from Benjamin Poulain <benjamin at webkit.org>  2013-08-11 21:08:45 PST ---
(In reply to comment #8)
> What is your view on avoiding inlining but keeping other modification.
> I have removed theme style access everytime in that fucntion which is redundant for each call.

I think it makes the class worse.

You are adding one more binary state to a class, and it is effectively a cold cache for the result of a virtual function of an other class.
In the context of managing software complexity, this change is not in the interest of the project.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.