[Webkit-unassigned] [Bug 119625] [Performance]making HTMLSelectElement::usesMenuList() inline

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=119625





--- Comment #8 from Santosh Mahto <santoshbit2007 at gmail.com>  2013-08-11 09:41:29 PST ---
(In reply to comment #7)

> (From update of attachment 208444 [details])

> The burden of proof is on the one making the change. You should benchmark your changes and provide the numbers for the improvement.
This patch is more of code refactoring with a goal of better function complexity.
Keeping [performance] in title is misguiding as I found now.Because patch is not of any benchmark improvement.
I ask sorry for this crime.

Please ignore the patch and close the bug if this refactoring is not allowed now.
.
> 
> Previously, all the calls to usesMenuList() were made in one instruction:
>     call _Whatever_The_Symbol_is_for_usesMenuList. 

> With your change, you will get something like this:
>     move 1 to r0
>     load byte from m_isThemeSpecifyMenuRendering to registerX


I agree code size will increase with  inlining (although runtime speed will be better , no fucntion call)

We can avoid making it inline.
What is your view on avoiding inlining but keeping other modification.
I have removed theme style access everytime in that fucntion which is redundant for each call.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.