[Webkit-unassigned] [Bug 119536] Refactor highestEditableRoot to avoid a redundant call to rendererIsEditable

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=119536


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #208236|review?                     |review-
               Flag|                            |




--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org>  2013-08-10 22:37:30 PST ---
(From update of attachment 208236)
View in context: https://bugs.webkit.org/attachment.cgi?id=208236&action=review

> Source/WebCore/editing/htmlediting.cpp:123
> +    if (highestRoot->hasTagName(bodyTag))
> +        return highestRoot;
> +
> +    node = highestRoot->parentNode();

Please don't repeat the code. We can rearrange the code inside the loop instead.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.