[Webkit-unassigned] [Bug 119513] [WebGL] compileShader map iterator validation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=119513





--- Comment #7 from Przemyslaw Szymanski <p.szymanski3 at samsung.com>  2013-08-08 22:39:24 PST ---
(In reply to comment #6)
> (From update of attachment 208172 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=208172&action=review
> 
> > Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:467
> > +        if (result == m_shaderSourceMap.end())
> > +            return;
> 
> what situation does the patch help?

It avoids possibly bug/crash. Assume m_shaderSourceMap does not contain search object. Then result iterator will point to m_shaderSourceMap.end() and read from it should crash. 
Look in other methods with use of m_shaderSourceMap.find. There are that checks too. I think someone forgot about this check here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.