[Webkit-unassigned] [Bug 99352] [GTK] [WebKit2] Add an 'authenticate' signal to WebKitWebView

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=99352





--- Comment #60 from Carlos Garcia Campos <cgarcia at igalia.com>  2013-08-08 11:06:21 PST ---
(In reply to comment #59)
> (From update of attachment 208349 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=208349&action=review
> 
> All changes have been applied - Carlos could you take a last look if they're ok and cq+?
> 
> > Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebView.cpp:1428
> > +        if (authorization && !strcmp(authorization, authExpectedAuthorization)) {
> 
> I tried g_strcmp0, but since authExpectedAuthorization is never NULL it always returns true and never gets through to sending a challenge.

g_strcmp0 doesn't return TRUE/False, but -1, 0, 1. It handles NULL by considering it lower than non NULL strings, but it will only return 0 if both are NULL or non-NULL and equal.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.