[Webkit-unassigned] [Bug 119513] [WebGL] compileShader map iterator validation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=119513


Andreas Kling <akling at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |akling at apple.com




--- Comment #5 from Andreas Kling <akling at apple.com>  2013-08-08 06:51:02 PST ---
(In reply to comment #4)
> (In reply to comment #3)
> > (From update of attachment 208172 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=208172&action=review
> > 
> > > Source/WebCore/ChangeLog:15
> > > +        No new tests. Covered by existing tests.
> > > +        LayoutTests/webgl/conformance/glsl/functions/glsl-function-abs.html
> > > +        LayoutTests/webgl/conformance/glsl/functions/glsl-function-acos.html
> > > +        LayoutTests/webgl/conformance/glsl/functions/glsl-function-length.html
> > 
> > These tests currently crash, or exhibit bad behavior?
> > If so, we should unskip them with this change.
> 
> Thank you for your review.
> These tests works fine. I ran them in the minibrowser directly. I ran Khronos conformance tests too. This patch does not break any webgl test.

If these tests work fine without the change, how is this "covered by existing tests"?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.