[Webkit-unassigned] [Bug 109422] [Qt] Add Page Visibility API support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=109422


Simon Hausmann <hausmann at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #208173|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #66 from Simon Hausmann <hausmann at webkit.org>  2013-08-06 03:06:55 PST ---
(From update of attachment 208173)
View in context: https://bugs.webkit.org/attachment.cgi?id=208173&action=review

Looks great! Three small finishing-touches type of nitpicks. But otherwise I love it. Small, compact but straight to the point.

> Source/WebKit/qt/WidgetApi/qwebpage.cpp:3152
> +/*!
> +    This method is used to change the page visibility state.

You can combine the docs for the setter and the getter into one snippet of documentation for the entire property. See the use of the \property tag in other places in the same file.

> Source/WebKit/qt/WidgetApi/qwebpage.cpp:3164
> +void QWebPage::setVisibilityState(QWebPage::VisibilityState state)

I think that you can remove the QWebPage:: prefix for the parameter

> Source/WebKit/qt/WidgetApi/qwebpage.h:220
> +    enum VisibilityState {

This new enum needs documentation that explains what the values mean :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.