[Webkit-unassigned] [Bug 118785] [GTK] Implement leak checking with valgrind

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=118785





--- Comment #14 from Zan Dobersek <zandobersek at gmail.com>  2013-08-05 13:01:36 PST ---
(From update of attachment 208133)
View in context: https://bugs.webkit.org/attachment.cgi?id=208133&action=review

> Tools/Scripts/webkitpy/port/gtk.py:71
> +        # Starting an application under Valgrind takes a lot longer than normal
> +        # so increase the timeout (empirically 10x is enough to avoid timeouts).
> +        multiplier = 10 if self.get_option("leaks") else 1
>          if self.get_option('configuration') == 'Debug':
> -            return 12 * 1000
> -        return 6 * 1000
> +            return multiplier * 12 * 1000
> +        return multiplier * 6 * 1000

This timeout value covers the maximum time each test is allowed to run, not the amount of time each DumpRenderTree/WebKitTestRunner instance takes to fire up and get ready for testing.

I assume that under Valgrind, you'd still want a prolonged timeout value (so applying the multiplier here is OK), but the comment is not technically correct.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.