[Webkit-unassigned] [Bug 118785] [GTK] Implement leak checking with valgrind

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=118785





--- Comment #10 from Brian Holt <brian.holt at samsung.com>  2013-08-05 10:15:04 PST ---
(From update of attachment 208129)
View in context: https://bugs.webkit.org/attachment.cgi?id=208129&action=review

Thanks for the review!  Since the other changes are so heavily dependent on this getting in I'm going to hold off uploading new versions of them until this gets in (hopefully soon)!

>> Tools/Scripts/webkitpy/port/gtk.py:92
>> +            environment['G_SLICE'] = 'always-malloc'
> 
> I understand that forcing malloc() for every single memory allocation is some kind of prerequisite to use valgrind here?
> 
> If so, a comment explaining the reason would be handy here too, as it's not obvious why we need this.

Good point - and in finding a link (https://wiki.gnome.org/Valgrind) I've found that I should also set G_DEBUG=gc-friendly.

>> Tools/Scripts/webkitpy/port/gtk.py:96
>> +                "--num-callers=40 " \
> 
> Nit. I would probably move this --tool parameter to the following line, so every option is aligned.

Sorry, you mentioned that last review but I missed it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.