[Webkit-unassigned] [Bug 118785] [GTK] Implement leak checking with valgrind

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=118785





--- Comment #9 from Mario Sanchez Prada <mario at webkit.org>  2013-08-05 10:04:30 PST ---
(From update of attachment 208129)
View in context: https://bugs.webkit.org/attachment.cgi?id=208129&action=review

Besides a small nit (which I'm not even sure whether others would agree with anyway), the patch now looks good to me, so I would say an official review would be in place now.

It's so beautiful to see it reduced to less than half of the original size! :)

> Tools/Scripts/webkitpy/port/gtk.py:92
> +            environment['G_SLICE'] = 'always-malloc'

I understand that forcing malloc() for every single memory allocation is some kind of prerequisite to use valgrind here?

If so, a comment explaining the reason would be handy here too, as it's not obvious why we need this.

> Tools/Scripts/webkitpy/port/gtk.py:96
> +            environment['VALGRIND_OPTS'] = "--tool=memcheck " \
> +                "--num-callers=40 " \

Nit. I would probably move this --tool parameter to the following line, so every option is aligned.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.