[Webkit-unassigned] [Bug 109422] [Qt] Add Page Visibility API support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=109422


Jocelyn Turcotte <jocelyn.turcotte at digia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jocelyn.turcotte at digia.com




--- Comment #55 from Jocelyn Turcotte <jocelyn.turcotte at digia.com>  2013-08-05 03:58:49 PST ---
(In reply to comment #54)
> > > Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.h:136
> > > +    // Must match with values of PageVisibilityState enum from PageVisibilityState.h.
> Initially I made a switch-case and then I delete it... :) For the default value, should I return the hidden value?
The default shouldn't happen as we should still try to maintain the match between the enums. So just put an ASSERT(FALSE) and return any reasonable default value.

> I agree, in the current implementation if the visibility API isn't enable the visibility attributes are available even so and set to hidden. That's why I used this default value.