[Webkit-unassigned] [Bug 109422] [Qt] Add Page Visibility API support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=109422


Jocelyn Turcotte <jocelyn.turcotte at digia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #207926|review?                     |review-
               Flag|                            |




--- Comment #53 from Jocelyn Turcotte <jocelyn.turcotte at digia.com>  2013-08-05 02:47:33 PST ---
(From update of attachment 207926)
View in context: https://bugs.webkit.org/attachment.cgi?id=207926&action=review

> Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.h:136
> +    // Must match with values of PageVisibilityState enum from PageVisibilityState.h.

I think we should do a switch-case matching in QWebPageAdapter::setVisibilityState to make sure that the enum values are independent from WebCore. It's usually not a good idea to have the public header follow internal enums directly.

> Source/WebKit/qt/WidgetApi/qwebpage.cpp:3161
> +    \note The initial state is set to PageVisibilityStateHidden if the page visibility API is enabled,
> +    otherwise is set to PageVisibilityApiUnavailable.

What about all applications out there not knowing about this new API, isn't it a bad default to have page told that they are hidden even though they are shown?

> Source/WebKit/qt/WidgetApi/qwebpage.h:220
> +    // Must match with values of PageVisibilityState enum from QWebPageAdapter.h.

Please leave this information in QWebPageAdapter.h not to pollute the public header.

> Source/WebKit/qt/WidgetApi/qwebpage.h:226
> +        PageVisibilityApiUnavailable

We should simply enable the compile-time flag all the time if we're exposing the API. A feature is usually not enabled only if it isn't implemented or ready.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.