[Webkit-unassigned] [Bug 106198] PreloadScanner preloads external CSS with non-matching media attribute

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Aug 3 04:40:14 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=106198


Dean Jackson <dino at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #197661|review?                     |review+
               Flag|                            |




--- Comment #29 from Dean Jackson <dino at apple.com>  2013-08-03 04:39:55 PST ---
(From update of attachment 197661)
View in context: https://bugs.webkit.org/attachment.cgi?id=197661&action=review

Looks ok. Just minor comments.

> Source/WebCore/ChangeLog:16
> +        * html/parser/HTMLPreloadScanner.cpp:
> +        (WebCore::TokenPreloadScanner::StartTagScanner::StartTagScanner):
> +        (WebCore::TokenPreloadScanner::StartTagScanner::createPreloadRequest):
> +        (WebCore::TokenPreloadScanner::StartTagScanner::processAttribute):
> +        (WebCore::TokenPreloadScanner::StartTagScanner::resourceType):
> +        (WebCore::TokenPreloadScanner::StartTagScanner::shouldPreload):
> +        (TokenPreloadScanner::StartTagScanner):

I'd really like some per-function comments here to make it clear what you're changing.

> Source/WebCore/html/parser/HTMLResourcePreloader.h:43
> +        return adoptPtr(new PreloadRequest(initiator, resourceURL, baseURL, resourceType, ""));

Use String() rather than "".

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list