[Webkit-unassigned] [Bug 119435] FrameView should have an isMainFrameView()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=119435





--- Comment #6 from Brady Eidson <beidson at apple.com>  2013-08-02 12:29:49 PST ---
(In reply to comment #5)
> (From update of attachment 207997 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=207997&action=review
> 
> > Source/WebCore/page/FrameView.cpp:427
> > +bool FrameView::isMainFrameView() const
> > +{
> > +    return m_frame && m_frame->page() && m_frame->page()->mainFrame() == m_frame;
> > +}
> > +
> 
> Does this do the right thing for a page in the page cache? What is the right thing?

A "web page" in the page cache is a much different concept than a WebCore::Page

WebCore::Page represents the browser tab.  And that WebCore::Page has a single WebCore::Frame that is ALWAYS the main frame of that tab, even across navigations.

I think this check is fine.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.