[Webkit-unassigned] [Bug 119417] Use op_get_by_id_custom_stub to fast access to JSCallbackObject's static value

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=119417


Geoffrey Garen <ggaren at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #207971|review?                     |review-
               Flag|                            |




--- Comment #3 from Geoffrey Garen <ggaren at apple.com>  2013-08-01 17:50:31 PST ---
(From update of attachment 207971)
This isn't quite right.

The API allows a client to specify an abstract hasProperty and/or getProperty callback, and that callback is allowed to return different results every time, making it incorrect to cache.

Please add a test to testapi that fails for this reason with your current patch.

That said, you may be able to rescue the basic idea of this optimization: You just need to modify your patch to be sure to poison all property access as uncacheable if anything in the class or prototype hierarchy specifies an abstract getProperty or hasProperty callback.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.