[Webkit-unassigned] [Bug 119356] [Forms: color] <input type='color'> popover color well implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=119356





--- Comment #14 from Brady Eidson <beidson at apple.com>  2013-08-01 10:01:50 PST ---
(From update of attachment 207901)
View in context: https://bugs.webkit.org/attachment.cgi?id=207901&action=review

> Source/WebKit2/UIProcess/WebPageProxy.cpp:1008
> +#if ENABLE(INPUT_TYPE_COLOR) && ENABLE(INPUT_TYPE_COLOR_POPOVER)

This preprocessor statement is unnecessary.

Enabling INPUT_TYPE_COLOR_POPOVER without enabling INPUT_TYPE_COLOR is an invalid build config.

I think each place you use this macro it should just be the INPUT_TYPE_COLOR_POPOVER clause by itself.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.