[Webkit-unassigned] [Bug 119078] [GTK] [EFL] Enable tiled shadow blur for the inset shadows.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=119078





--- Comment #3 from Alejandro G. Castro <alex at igalia.com>  2013-08-01 05:17:31 PST ---
(In reply to comment #2)
> (From update of attachment 207444 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=207444&action=review
> 
> Nice. Just a couple suggestions before landing.
> 
> > Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:1054
> > +    if (!roundedHoleRect.radii().isZero())
> > +        path.addRoundedRect(roundedHoleRect);
> > +    else
> > +        path.addRect(roundedHoleRect.rect());
> 
> I wonder if this optimization should go into Path.cpp eventually?
>

Good point, not sure, I can check it in a follow-up patch.

> > Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:1061
> > +    setFillRule(RULE_EVENODD);
> > +    setFillColor(color, colorSpace);
> 
> I think that instead of setting the fill rule and color for the GraphicsContext you should just set them for the Cairo context. That way you can use cairo_save/cairo_restore, instead of oldFillRule and oldFillColor.
> 

Yep, it sounds better option.

> > Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:1065
> > +        ShadowBlur& shadow = platformContext()->shadowBlur();
> > +        shadow.drawInsetShadow(this, rect, roundedHoleRect.rect(), roundedHoleRect.radii());
> 
> I think you can avoid the temporary and move this code to the very start of the method after the early return.

Ok,

Thanks for the review.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.