[Webkit-unassigned] [Bug 120540] Use Element& in StyleResolveTree

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=120540


Andreas Kling <akling at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #210137|review?                     |review+
               Flag|                            |




--- Comment #2 from Andreas Kling <akling at apple.com>  2013-08-30 11:23:47 PST ---
(From update of attachment 210137)
View in context: https://bugs.webkit.org/attachment.cgi?id=210137&action=review

r=me.

Obligatory whining about places where reasons for dereference safety is not immediately clear:

> Source/WebCore/dom/ContainerNode.cpp:108
>  static inline void attachChild(Node* child)

This should take a Node&.

> Source/WebCore/dom/ContainerNode.cpp:116
>  static inline void detachChild(Node* child)

This should take a Node&.

> Source/WebCore/dom/Element.cpp:2303
> +    Style::resolveTree(*existingPseudoElement, needsStyleRecalc() ? Style::Force : change);

This function should take a PseudoElement& instead of a PseudoElement*.

> Source/WebCore/style/StyleResolveTree.cpp:472
> +    PostAttachCallbackDisabler callbackDisabler(&current);

We should make this RAII object take a ContainerNode& instead.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.