[Webkit-unassigned] [Bug 103771] [GStreamer] support in-band text tracks

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=103771





--- Comment #147 from Jer Noble <jer.noble at apple.com>  2013-08-30 09:41:27 PST ---
(From update of attachment 210033)
View in context: https://bugs.webkit.org/attachment.cgi?id=210033&action=review

> Source/WebCore/html/track/InbandGenericTextTrack.cpp:156
> +        LOG(Media, "InbandTextTrack::addGenericCue ignoring already added cue: start=%.2f, end=%.2f, content=\"%s\"\n", cueData->startTime(), cueData->endTime(), cueData->content().utf8().data());

This should probably be fixed to log the new class name.

> Source/WebCore/html/track/InbandGenericTextTrack.cpp:182
> +        LOG(Media, "InbandTextTrack::removeGenericCue removing cue: start=%.2f, end=%.2f, content=\"%s\"\n", cueData->startTime(), cueData->endTime(), cueData->content().utf8().data());

Ditto.

> Source/WebCore/html/track/InbandWebVTTTextTrack.h:56
> +class WebVTTTextTrackCueMap {
> +public:
> +    WebVTTTextTrackCueMap();
> +    virtual ~WebVTTTextTrackCueMap();
> +
> +    void add(WebVTTCueData*, TextTrackCue*);
> +
> +    void remove(TextTrackCue*);
> +    void remove(WebVTTCueData*);
> +
> +    PassRefPtr<WebVTTCueData> find(TextTrackCue*);
> +    PassRefPtr<TextTrackCue> find(WebVTTCueData*);
> +
> +private:
> +    typedef HashMap<RefPtr<TextTrackCue>, RefPtr<WebVTTCueData> > CueToDataMap;
> +    typedef HashMap<RefPtr<WebVTTCueData>, RefPtr<TextTrackCue> > CueDataToCueMap;
> +
> +    CueToDataMap m_cueToDataMap;
> +    CueDataToCueMap m_dataToCueMap;
> +};

It might be nice to templatize this class, since it's essentially duplicated in both this and InbandGenericTextTrack.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.