[Webkit-unassigned] [Bug 117405] [EFL]Background Style of element not visible because of default theme style

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117405





--- Comment #23 from Santosh Mahto <santosh.ma at samsung.com>  2013-08-29 07:40:26 PST ---
(From update of attachment 209955)
View in context: https://bugs.webkit.org/attachment.cgi?id=209955&action=review

>> Source/WebCore/platform/efl/DefaultTheme/widget/combo/combo.edc:35
>> +        image: "widget/combo/combo_press_button_styled.png" COMP;
> 
> Why do you only add these for press state ?
> 
> I think that we also need normal (at least).

sorry, combo_styled.png would have better name here.

Actually there are 4 state(hover/focus/press/default) and 4 image change.
When background color is specified I am going for only 1 state as there is not much display difference.
To manipulate the state in background color also I need to double the behaviour in the combo.edc again 
for 4 new states images.
so after your comment i have 3 choice in case of styled combo:
1.No state.
2.Only default(normal).
3. All 4 state 
If 2nd option is ok I would like  go ahead.

>> Source/WebCore/platform/efl/DefaultTheme/widget/combo/combo.edc:331
>> +        }
> 
> Like other signals, we can use show() to change state.

So again How many state change is enough (0 or 1 or all 4)

>> Source/WebCore/platform/efl/RenderThemeEfl.cpp:379
>> +    bool bgStyled = object && object->hasBackground() && object->style()->visitedDependentColor(CSSPropertyBackgroundColor) != Color::white;
> 
> I am not sure, but I didn't see this coding style in WebKit.

Hmm, will check for something better. probably can use RenderTheme::isControlStyled.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.