[Webkit-unassigned] [Bug 117405] [EFL]Background Style of element not visible because of default theme style

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117405





--- Comment #21 from Ryuan Choi <ryuan.choi at samsung.com>  2013-08-29 05:40:32 PST ---
(From update of attachment 209955)
View in context: https://bugs.webkit.org/attachment.cgi?id=209955&action=review

Did you run layout test with pixel-tests?

> Source/WebCore/platform/efl/DefaultTheme/widget/combo/combo.edc:35
> +        image: "widget/combo/combo_press_button_styled.png" COMP;

Why do you only add these for press state ?

I think that we also need normal (at least).

> Source/WebCore/platform/efl/DefaultTheme/widget/combo/combo.edc:144
> +		image {

Indentation looks wrong

> Source/WebCore/platform/efl/DefaultTheme/widget/combo/combo.edc:331
> +        }

Like other signals, we can use show() to change state.

> Source/WebCore/platform/efl/RenderThemeEfl.cpp:297
> +void RenderThemeEfl::applyEdjeStateFromForm(Evas_Object* object, ControlStates states, bool isStyled)

ambiguous variable name to me.

> Source/WebCore/platform/efl/RenderThemeEfl.cpp:320
> +        }

It looks not bad to me, but you should send new signal without touching current signals.

> Source/WebCore/platform/efl/RenderThemeEfl.cpp:379
> +    bool bgStyled = object && object->hasBackground() && object->style()->visitedDependentColor(CSSPropertyBackgroundColor) != Color::white;

I am not sure, but I didn't see this coding style in WebKit.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.