[Webkit-unassigned] [Bug 120441] New: Remove unneeded setNeedsLayouts from RenderTableSection
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Aug 28 16:21:25 PDT 2013
https://bugs.webkit.org/show_bug.cgi?id=120441
Summary: Remove unneeded setNeedsLayouts from
RenderTableSection
Product: WebKit
Version: 528+ (Nightly build)
Platform: Unspecified
OS/Version: Unspecified
Status: NEW
Keywords: BlinkMergeCandidate
Severity: Normal
Priority: P2
Component: Layout and Rendering
AssignedTo: webkit-unassigned at lists.webkit.org
ReportedBy: rniwa at webkit.org
CC: hyatt at apple.com, bdakin at apple.com,
simon.fraser at apple.com, dino at apple.com,
robert at webkit.org
Consider merging https://chromium.googlesource.com/chromium/blink/+/8e2f19c539881025022d3ff799066a06a95bc490
As best I can tell, these setNeedsLayouts don't accomplish anything.
Elliott and I dug through the changes that added them. The tests
added with those patches pass without the setNeedsLayouts. We tried
for a while to come up with a test case the setNeedsLayouts were
needed and couldn't.
The cellChildrenFlex part is needed though so that we only call
setOverrideLogicalContentHeightFromRowHeight in the right cases.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list