[Webkit-unassigned] [Bug 120407] Resolve unused parameter warning in WebKitAccessibleInterfaceText.cpp

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 28 09:41:52 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=120407


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #209872|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #3 from Darin Adler <darin at apple.com>  2013-08-28 09:41:15 PST ---
(From update of attachment 209872)
Since this function is local to this file, it doesn't make sense to pass and ignore an argument. We should just remove this argument from this function and all the call sites.

I think it’s better style to just remove the argument name entirely rather than commenting it out, but it’s debatable I suppose. I also think the spacing inside the /* */ draws too much attention to the unused argument.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list