[Webkit-unassigned] [Bug 120402] Don't use NodeRenderingContext when attaching text renderers

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=120402


Andreas Kling <akling at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #209865|review?                     |review+
               Flag|                            |




--- Comment #2 from Andreas Kling <akling at apple.com>  2013-08-28 05:31:49 PST ---
(From update of attachment 209865)
View in context: https://bugs.webkit.org/attachment.cgi?id=209865&action=review

r=me

> Source/WebCore/style/StyleResolveTree.cpp:210
> +static void crateTextRendererIfNeeded(Text* textNode)

Typo, cr_e_ate.

> Source/WebCore/style/StyleResolveTree.cpp:276
> +    RenderText* textRenderer = toRenderText(textNode->renderer());

We could add a tightly-typed override and avoid casts like this:
RenderText* Text::renderer() const;

> Source/WebCore/style/StyleResolveTree.h:56
> +void attachTextRenderer(Text*);
> +void detachTextRenderer(Text*);
> +void updateTextRendererAfterContentChange(Text*, unsigned offsetOfReplacedData, unsigned lengthOfReplacedData);

Can we make these take Text& instead? They shouldn't have to deal with null inputs.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.