[Webkit-unassigned] [Bug 120401] New: [GTK][WTR] Several editing/selection tests are flaky as ClickCounter is not reset between test runs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=120401

           Summary: [GTK][WTR] Several editing/selection tests are flaky
                    as ClickCounter is not reset between test runs
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Keywords: Gtk, LayoutTestFailure
          Severity: Normal
          Priority: P2
         Component: WebKit Gtk
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: simon.pena at samsung.com


WebKitWebViewBase has a ClickCounter helper class to handle single-clicks, double-clicks, triple-clicks and so on: http://trac.webkit.org/browser/trunk/Source/WebCore/platform/gtk/GtkClickCounter.h

WebKitTestRunner uses EventSenderProxy to create and dispatch GdkEvents with the mouse event. In TestController::resetStateToConsistentValues(), the EventSenderProxy is destroyed after every test run, which should clear existing click counts, previous click locations and other mouse event related state. However, since the internal ClickCounter is not cleared, and as it is used in webkitWebViewBaseButtonPressEvent to create NativeWebMouseEvent from the GdkEvents received, these new NativeWebMouseEvents carry the existing click count.

The tests are simply flaky: when they are run in their own WebKitTestRunner, they will pass. This shouldn't affect the regular browsing behaviour, as the ClickCounter uses the event time and click location to tell whether a click is a different event or part of the previous one. However, I still think it should be fixed, as it can be misleading when analysing test results.

I will now upload a patch that resets the click counter in the resetStateToConsistentValues, and also in the WEBKIT_LOAD_STARTED state. Let me know what you think.

You can try this yourself by running 

Tools/Scripts/run-webkit-tests --repeat-each=2 --gtk -2 editing/selection/anchor-focus1.html \
editing/selection/anchor-focus2.html \
editing/selection/anchor-focus3.html \
editing/selection/block-with-positioned-lastchild.html \
editing/selection/caret-after-keypress.html \
editing/selection/crash-on-shift-click.html \
editing/selection/doubleclick-beside-cr-span.html \
editing/selection/doubleclick-crash.html \
editing/selection/doubleclick-inline-first-last-contenteditable.html \
editing/selection/doubleclick-whitespace.html \
editing/selection/drag-select-1.html \
editing/selection/drag-select-rapidly.html \
editing/selection/drag-start-event-client-x-y.html \
editing/selection/editable-links.html \
editing/selection/expanding-selections.html \
editing/selection/expanding-selections2.html \
editing/selection/fake-doubleclick.html \
editing/selection/fake-drag.html \
editing/selection/focus-and-display-none.html \
editing/selection/focus-crash.html \
editing/selection/hit-test-anonymous.html \
editing/selection/hit-test-on-text-with-line-height.html \
editing/selection/inline-closest-leaf-child.html \
editing/selection/last-empty-inline.html \
editing/selection/mixed-editability-1.html \
editing/selection/move-begin-end.html \
editing/selection/paragraph-granularity.html \
editing/selection/rtl-move-selection-right-left.html \
editing/selection/select-across-readonly-input-1.html \
editing/selection/select-across-readonly-input-2.html \
editing/selection/select-across-readonly-input-3.html \
editing/selection/select-across-readonly-input-4.html \
editing/selection/select-across-readonly-input-5.html \
editing/selection/select-all-iframe.html \
editing/selection/select-bidi-run.html \
editing/selection/select-from-textfield-outwards.html \
editing/selection/select-line-break-with-opposite-directionality.html \
editing/selection/select-out-of-editable.html \
editing/selection/select-out-of-floated-contenteditable.html \
editing/selection/select-out-of-floated-input.html \
editing/selection/select-out-of-floated-textarea.html \
editing/selection/selection-actions.html

I took this list from http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20WK2%20%28Tests%29/builds/7907/steps/layout-test/logs/stdio. I removed editing/selection/empty-cell-right-click.html, which seems to cause a different issue and that I am investigating on its own.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.