[Webkit-unassigned] [Bug 120002] [CSS Masking] Add -webkit-mask-source-type shorthand property

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=120002


Dirk Schulze <krit at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #209066|review?                     |review-
               Flag|                            |




--- Comment #2 from Dirk Schulze <krit at webkit.org>  2013-08-28 03:52:11 PST ---
(From update of attachment 209066)
View in context: https://bugs.webkit.org/attachment.cgi?id=209066&action=review

Looks good to me. Just some snippets.

> Source/WebCore/css/CSSParser.cpp:2847
> +        const CSSPropertyID properties[] = { CSSPropertyWebkitMaskImage, CSSPropertyWebkitMaskRepeat, CSSPropertyWebkitMaskSourceType,

Put this right after MaskImage to match the spec please.

> Source/WebCore/css/StylePropertyShorthand.cpp:441
> +        CSSPropertyWebkitMaskSourceType

Put this right after MaskImage to match the spec please.

> Source/WebCore/css/StylePropertyShorthand.cpp:888
> +        map.set(CSSPropertyWebkitMaskSourceType, mask);

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.