[Webkit-unassigned] [Bug 120398] REGRESSION(R154708): It broke all plugin tests on GTK and Qt WK1

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=120398





--- Comment #1 from Zan Dobersek <zandobersek at gmail.com>  2013-08-28 03:05:50 PST ---
Looking at the offending patch:

Index: /trunk/Source/WebCore/bridge/c/c_class.cpp
===================================================================
--- /trunk/Source/WebCore/bridge/c/c_class.cpp    (revision 154707)
+++ /trunk/Source/WebCore/bridge/c/c_class.cpp    (revision 154708)
...
@@ -94,16 +91,16 @@
     String name(propertyName.publicName());

-    Field* aField = _fields.get(name.impl());
-    if (aField)
-        return aField;
-    
+    if (Field* field = m_fields.get(name.impl()))
+        return field;
+
     NPIdentifier ident = _NPN_GetStringIdentifier(name.ascii().data());
     const CInstance* inst = static_cast<const CInstance*>(instance);
     NPObject* obj = inst->getObject();
-    if (_isa->hasProperty && _isa->hasProperty(obj, ident)){
-        aField = new CField(ident); // deleted in the CClass destructor
-        _fields.set(name.impl(), aField);
+    if (m_isa->hasProperty && m_isa->hasProperty(obj, ident)) {
+        OwnPtr<Field> field = adoptPtr(new CField(ident));
+        m_fields.set(name.impl(), field.release());
     }
-    return aField;
+
+    return 0;
 }


The last return seems to break the previous behavior.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.