[Webkit-unassigned] [Bug 118553] Hash navigation doesn't affect history when the page is retrieved from appcache

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=118553


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #209743|review?                     |review+
               Flag|                            |




--- Comment #8 from Darin Adler <darin at apple.com>  2013-08-27 09:57:46 PST ---
(From update of attachment 209743)
View in context: https://bugs.webkit.org/attachment.cgi?id=209743&action=review

> Source/WebCore/loader/appcache/ApplicationCacheHost.cpp:89
> +            substituteData = SubstituteData(resource->data(),
>                                              resource->response().mimeType(),
>                                              resource->response().textEncodingName(), KURL());
> +            substituteData.setShouldRevealToSessionHistory(true);

One further thought. Since the only caller is setting this at construction time, would be nice to just set this in the constructor, leave out setShouldRevealToSessionHistory entirely, and maybe even make m_shouldRevealToSessionHistory const.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.