[Webkit-unassigned] [Bug 118860] [Qt] Add a an isMainFrame property to the QWebNavigationRequest QtWebkit2 API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=118860





--- Comment #8 from Alexandre Abreu <alexandre.abreu at canonical.com>  2013-08-27 06:42:27 PST ---
(In reply to comment #6)
> (From update of attachment 207138 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=207138&action=review
> 
> > Source/WebKit/qt/declarative/plugin.cpp:60
> > -        qmlRegisterUncreatableType<QWebNavigationRequest>(uri, 3, 0, "NavigationRequest", QObject::tr("Cannot create separate instance of NavigationRequest"));
> > +        qmlRegisterUncreatableType<QWebNavigationRequest, 1>(uri, 3, 1, "NavigationRequest", QObject::tr("Cannot create separate instance of NavigationRequest"));
> 
> I think you may want to keep both lines, in order to continue to be able to instantiate the 3.0 version.
> 
> Looks good to me otherwise!

right, done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.