[Webkit-unassigned] [Bug 120322] AX: Cancel button in search field not accessible.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=120322





--- Comment #1 from Samuel White <samuel_white at apple.com>  2013-08-26 16:50:54 PST ---
Created an attachment (id=209692)
 --> (https://bugs.webkit.org/attachment.cgi?id=209692&action=review)
Preliminary patch for feedback.

No review needed, just looking for feedback. Thanks.

This button is rather hard to uniquely identify. For this patch I've used the shadowPseudoId which seems a bit fragile. Would adding isSearchFieldCancelButton() or something similar to Element be acceptable? I see other methods with this purpose:

isFormControlElement
isSpinButtonElement
isTextFormControl

I see that the way accessible text is derived is changing at some point (see the comment "Accessibility Text - (To be deprecated)" in AccessibilityObject.h). I've structured my implementation to satisfy all platforms (I believe) with the thought that the OVERRIDE macro will make sure my implementation is updated when this move finished. Thoughts?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.