[Webkit-unassigned] [Bug 120277] New: JSHTMLFormElement::canGetItemsForName needlessly allocates a Vector

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=120277

           Summary: JSHTMLFormElement::canGetItemsForName needlessly
                    allocates a Vector
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Bindings
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: rniwa at webkit.org
                CC: sam at webkit.org, koivisto at iki.fi, akling at apple.com


There's no reason for JSHTMLFormElement::canGetItemsForName to be allocating a Vector since it only needs to figure out if there is a named item or not:

bool JSHTMLFormElement::canGetItemsForName(ExecState*, HTMLFormElement* form, PropertyName propertyName)
{
    Vector<RefPtr<Node> > namedItems;
    form->getNamedElements(propertyNameToAtomicString(propertyName), namedItems);
    return namedItems.size();
}

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.