[Webkit-unassigned] [Bug 103377] [GTK] Add WebKit2 API for isolated worlds

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=103377





--- Comment #7 from Carlos Garcia Campos <cgarcia at igalia.com>  2013-08-24 04:08:26 PST ---
(In reply to comment #6)
> (From update of attachment 209352 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=209352&action=review
> 
> Looks good to me as well.

Thanks!

> > Source/WebKit2/UIProcess/API/gtk/tests/WebExtensionTest.cpp:154
> > +        const char *script;
> 
> Nit: asterisk location

Ooops

> > Source/WebKit2/WebProcess/InjectedBundle/API/gtk/WebKitScriptWorld.cpp:88
> > +    return scriptWorlds().get(scriptWorld);
> 
> This returns null if the world isn't in the map?

Yes.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.