[Webkit-unassigned] [Bug 117039] [GStreamer] Support audio and video tracks

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117039





--- Comment #49 from Eric Carlson <eric.carlson at apple.com>  2013-08-23 10:13:23 PST ---
(From update of attachment 209391)
View in context: https://bugs.webkit.org/attachment.cgi?id=209391&action=review

> Source/WebCore/ChangeLog:32
> +        (WebCore::HTMLMediaElement::audioTrackEnabledChanged):
> +        (WebCore::HTMLMediaElement::videoTrackSelectedChanged):
> +        * html/track/AudioTrack.cpp:
> +        (WebCore::AudioTrack::setEnabled):
> +        (WebCore::AudioTrack::audioTrackPrivateEnabledChanged):
> +        (WebCore::AudioTrack::audioTrackPrivateLabelChanged):
> +        (WebCore::AudioTrack::audioTrackPrivateLanguageChanged):
> +        * html/track/AudioTrack.h:
> +        * html/track/VideoTrack.cpp:
> +        (WebCore::VideoTrack::setSelected):
> +        (WebCore::VideoTrack::videoTrackPrivateSelectedChanged):
> +        (WebCore::VideoTrack::videoTrackPrivateLabelChanged):
> +        (WebCore::VideoTrack::videoTrackPrivateLanguageChanged):

Nit: please either add comments about what a new method does or what has been changed. If it isn't worth a comment remove the entry from ChangeLog.

> LayoutTests/ChangeLog:14
> +        * media/content/two-audio-and-video-tracks.mkv: Added.
> +        * media/track/audio/audio-track-mkv-vorbis-addtrack.html: Added.
> +        * media/track/audio/audio-track-mkv-vorbis-enabled.html: Added.
> +        * media/track/audio/audio-track-mkv-vorbis-language.html: Added.
> +        * media/track/video/video-track-mkv-theora-addtrack.html: Added.
> +        * media/track/video/video-track-mkv-theora-language.html: Added.
> +        * media/track/video/video-track-mkv-theora-selected.html: Added.

Rather than making all of these format specific, could you use findMediaFile() (or something equivalent) so these basic tests can work with every port that supports the feature?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.