[Webkit-unassigned] [Bug 119417] Use op_get_by_id_custom_stub to fast access to JSCallbackObject's static value

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=119417





--- Comment #7 from Yi Shen <max.hong.shen at gmail.com>  2013-08-21 16:15:52 PST ---
should we skip the style check for the API/tests/testapi.c ?
(In reply to comment #6)
> Attachment 208682 [details] did not pass style-queue:
> 
> Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSCallbackObject.h', u'Source/JavaScriptCore/API/JSCallbackObjectFunctions.h', u'Source/JavaScriptCore/API/JSClassRef.cpp', u'Source/JavaScriptCore/API/JSClassRef.h', u'Source/JavaScriptCore/API/tests/testapi.c', u'Source/JavaScriptCore/API/tests/testapi.js', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/runtime/PropertySlot.h', u'Source/JavaScriptCore/runtime/PutPropertySlot.h']" exit_code: 1
> Source/JavaScriptCore/API/tests/testapi.c:678:  MyCacheableObject_get_cacheableStaticValue is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
> Source/JavaScriptCore/API/tests/testapi.c:694:  CacheableObject_definition is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
> Source/JavaScriptCore/API/tests/testapi.c:717:  MyCacheableObject_class is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
> Source/JavaScriptCore/API/tests/testapi.c:728:  MyUncacheableObject_getProperty is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
> Source/JavaScriptCore/API/tests/testapi.c:744:  MyUncacheableObject_get_uncacheableStaticValue is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
> Source/JavaScriptCore/API/tests/testapi.c:758:  UncacheableObject_definition is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
> Source/JavaScriptCore/API/tests/testapi.c:781:  MyUncacheableObject_class is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
> Total errors found: 7 in 9 files
> 
> 
> If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.