[Webkit-unassigned] [Bug 120059] Add support for maction at toggle

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=120059





--- Comment #2 from chris fleizach <cfleizach at apple.com>  2013-08-21 16:13:37 PST ---
(From update of attachment 209175)
View in context: https://bugs.webkit.org/attachment.cgi?id=209175&action=review

> LayoutTests/mathml/presentation/maction-toggle.html:5
> +    <meta charset="utf-8"/>

this looks like it could be removed

> LayoutTests/mathml/presentation/maction-toggle.html:9
> +      var event = new MouseEvent('click', {bubbles: bubble, cancelable: true});

need some more indentation here

> LayoutTests/mathml/presentation/maction-toggle.html:17
> +      click('m1'); click('m1'); click('m1');

indentation needed

you might add a comment here explaining the different clicking happening

> Source/WebCore/mathml/MathMLSelectElement.cpp:42
> +class MactionEventListener : public EventListener {

I think the name should be MActionEventListener,

sort of like GObjectEventListener

> Source/WebCore/mathml/MathMLSelectElement.cpp:163
> +    int selection = (hasAttribute(MathMLNames::selectionAttr) ? getAttribute(MathMLNames::selectionAttr).toInt(&ok) : 1);

looks like this int could be unsigned

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.