[Webkit-unassigned] [Bug 119791] [Qt] Remove the fix in QWebPage::javaScriptConsoleMessage introduced by (r61433)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=119791





--- Comment #4 from Jocelyn Turcotte <jocelyn.turcotte at digia.com>  2013-08-21 09:23:19 PST ---
(From update of attachment 209266)
View in context: https://bugs.webkit.org/attachment.cgi?id=209266&action=review

> Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:166
> +    // lead(eg: calling window.alert from window.onunload) to call the 
> +    // virtual functions of the partially deleted WebPage object.
> +    // At this point vptr of QWebPage points to the derived class WebPage.

This is enough information but still too confusing:
- "from ~QWebPage will lead" -> "from ~QWebPage would lead". You want to avoid it.
- It won't "call the virtual functions of the partially deleted WebPage object" in ~QWebPage, it will call virtual functions of QWebPage as the WebPage part of the vtable has already been unwinded.
- "At this point vptr of QWebPage points to the derived class WebPage.", at which point, I assume that you mean here in ~WebPage? Please clarify.
- "vptr of QWebPage" -> "the vtable of QWebPage"
- "eg" -> "e.g."

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.