[Webkit-unassigned] [Bug 119905] [iOS] Upstream Source/WTF

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=119905





--- Comment #5 from Joseph Pecoraro <joepeck at webkit.org>  2013-08-19 12:25:31 PST ---
> > > Source/WTF/wtf/Platform.h:1009
> > > +#if (PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 70000) || ((PLATFORM(MAC) || (OS(WINDOWS) && USE(CG))) && !PLATFORM(IOS) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 1090)
> > 
> > Do we really need && __IPHONE_OS_VERSION_MIN_REQUIRED >= 70000?
> > It's not like we support anything before that.
> > 
> > You should get rid of the !PLATFORM(IOS) later in the list, it makes the #ifdef hard to follow.
> 
> I will remove this. I don't think anyone is compiling older iOS WebKits.
> 
> That said, the PLATFORM(IOS) later in the statement should only have been needed for iOS versions older then 70000, so I can now remove that.

On second thought, I want to keep them in. It is easy to remove them later if we wish. Mac does this with their features and it seems useful for documentation. For example this one as well in Platform.h:

   #if (PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 60000) || (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 1080)
  #define WTF_USE_COREMEDIA 1
  #endif

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.