[Webkit-unassigned] [Bug 119938] Animate CSS Image filter() function

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 19 11:11:00 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=119938





--- Comment #12 from Antti Koivisto <koivisto at iki.fi>  2013-08-19 11:10:29 PST ---
(From update of attachment 209079)
View in context: https://bugs.webkit.org/attachment.cgi?id=209079&action=review

> Source/WebCore/page/animation/CSSPropertyAnimation.cpp:217
> +    CSSFilterImageValue* fromValue = static_cast<CSSFilterImageValue*>(from->data());
> +    CSSFilterImageValue* toValue = static_cast<CSSFilterImageValue*>(to->data());

You should use you casting functions here too.

> Source/WebCore/page/animation/CSSPropertyAnimation.cpp:321
> +        CSSImageGeneratorValue* fromGenerated = static_cast<CSSImageGeneratorValue*>(from->data());
> +        CSSImageGeneratorValue* toGenerated = static_cast<CSSImageGeneratorValue*>(to->data());

The could have casting functions.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list