[Webkit-unassigned] [Bug 119960] Remove some optimizations made obsolete by use of StringBuilder

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Aug 17 14:48:31 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=119960


Andreas Kling <akling at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #209009|review?                     |review+
               Flag|                            |




--- Comment #2 from Andreas Kling <akling at apple.com>  2013-08-17 14:48:02 PST ---
(From update of attachment 209009)
View in context: https://bugs.webkit.org/attachment.cgi?id=209009&action=review

r=me with the cool stories we shared on IRC.

We should clean this up in StyleElement::process(), too.

> Source/WebCore/dom/ScriptElement.cpp:399
> +    for (Text* textNode = TextNodeTraversal::firstChild(m_element); textNode; textNode = TextNodeTraversal::nextSibling(textNode))
> +        content.append(textNode->data());

Can't you use TextNodeTraversal::contentsAsString() instead here?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list